style: resolve logical properties issue with dropdown #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflips
approved these changes
Nov 6, 2024
QuintonJason
changed the title
monicawheeler
approved these changes
Nov 6, 2024
Merged
ju-Skinner
pushed a commit
that referenced
this pull request
Nov 6, 2024
* chore(deps): bump @pine-ds/icons from 8.6.0 to 8.10.0 (#2019) Bumps [@pine-ds/icons](https://github.com/Kajabi/pine-icons) from 8.6.0 to 8.10.0. - [Release notes](https://github.com/Kajabi/pine-icons/releases) - [Changelog](https://github.com/Kajabi/pine-icons/blob/main/CHANGELOG.md) - [Commits](Kajabi/pine-icons@v8.6.0...v8.10.0) --- updated-dependencies: - dependency-name: "@pine-ds/icons" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * style: resolve logical properties issue with dropdown (#2020) * style: update physical properties to not use logical props * Revert "style: update physical properties to not use logical props" This reverts commit 18d20e0. * style: update incorrect logical properties --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Testing in
sage-libVisit the dropdown page and verify that they none span the entire page - Dropdown view
Testing in
kajabi-productsRelated